> 'svc_create_memory_pool()' returns an error pointer on error, not NULL. Such information is helpful. > Fix the corresponding test and return value accordingly. > > Move the genpool allocation after a few devm_kzalloc in order to ease > error handling. How do you think about a wording variant like the following? Change description: * Use a check of the failure predicate which is documented for the svc_create_memory_pool() function in the same source file. * Move the genpool allocation behind a few devm_kzalloc() calls in order to ease exception handling. Regards, Markus