On Mon, Apr 06, 2020 at 12:22:51PM -0400, Kazlauskas, Nicholas wrote:
> On 2020-04-06 5:19 a.m., Dan Carpenter wrote:
> > This TODO stub originally had curly braces but we deleted them as part
> > of a clean up. Unfortunately that changes the behavior of the code
> > because now the switch statement is part of the if statement. Smatch
> > complains that the indenting doesn't make sense.
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:425
> > link_detect_sink() warn: if statement not indented
> >
> > Also I changed "ZAZTODO" to just "TODO". The ZAZ isn't used anywhere
> > else.
> >
> > Fixes: 621514aa4140 ("drm/amd/display: codestyle cleanup on dc_link file until detect_dp func")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> I'd prefer just dropping the block, but either method is:
>
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx>
>
> Since that previous patch broke most sink detection...
>
Sorry for the net-next in the subject. Anyway, this was fixed in
commit 50dc581a8f43 ("drm/amd/display: fix the broken logic in dc_link.c")
so no need for me to resend.
regards,
dan carpenter
