On 2020-04-06 5:19 a.m., Dan Carpenter wrote:
This TODO stub originally had curly braces but we deleted them as part
of a clean up. Unfortunately that changes the behavior of the code
because now the switch statement is part of the if statement. Smatch
complains that the indenting doesn't make sense.
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:425
link_detect_sink() warn: if statement not indented
Also I changed "ZAZTODO" to just "TODO". The ZAZ isn't used anywhere
else.
Fixes: 621514aa4140 ("drm/amd/display: codestyle cleanup on dc_link file until detect_dp func")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
I'd prefer just dropping the block, but either method is:
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx>
Since that previous patch broke most sink detection...
Regards,
Nicholas Kazlauskas
---
Another idea is we should just delete this stub. Stub code is generally
against kernel style. I can send a V2 if people want.
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index a93997ff0419..188670d374a3 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -423,7 +423,7 @@ static enum signal_type link_detect_sink(struct dc_link *link,
/* PCIE detects the actual connector on add-on board */
if (link->link_id.id == CONNECTOR_ID_PCIE)
- /* ZAZTODO implement PCIE add-on card detection */
+ ; /* TODO implement PCIE add-on card detection */
switch (link->link_id.id) {
case CONNECTOR_ID_HDMI_TYPE_A: {
