Re: [PATCH] ipmi: bt-bmc: Avoid unnecessary judgement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>, openipmi-developer@xxxxxxxxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Corey Minyard <minyard@xxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] ipmi: bt-bmc: Avoid unnecessary judgement
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Fri, 3 Apr 2020 21:26:47 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

> In this function,it will only trigger ifdevice and driver match,and
> the driver has already used the device tree, so the judgement here is
> unnecessary.

Please improve also this commit message (besides a typo).

Regards,
Markus

Prev by Date: Re: [PATCH] ipmi: bt-bcm: Use platform_get_irq_optional()
Next by Date: Re: [PATCH] pwm: meson: remove redundant assignment to variable fin_freq
Previous by thread: Re: [PATCH] ipmi: bt-bcm: Use platform_get_irq_optional()
Next by thread: Re: [PATCH] mailbox: armada-37xx-rwtm: Remove duplicate error messages in armada_37xx_mbox_probe()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux