On Thu, Nov 21, 2019 at 11:40:28AM +0100, Markus Elfring wrote:
> > + err = exfat_map_cluster(inode, clu_offset, &cluster,
> > + *create & BMAP_ADD_CLUSTER);
>
> I find an other indentation more appropriate.
> Please align the last parameter below (or besides) the opening parenthesis.
It is great that you find that, but I think we can leave this to
the code author. We have plenty of example for opening brace aligned,
one or two tabs alignments in the code, and it is up to the author /
maintainer to chose one. No need to to nitpick their choices inside the
boundaries of the normal coding space.
> > + if (err) {
> > + if (err != -ENOSPC)
> > + return -EIO;
> > + return err;
> > + }
>
> Can such source code become more succinct?
>
> + if (err)
> + return err != -ENOSPC ? -EIO : err;
If it sufficient but a lot harder to follow.
