Re: [PATCH v4 03/13] exfat: add inode operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



…
> +++ b/fs/exfat/inode.c
…
> +static int exfat_bmap(struct inode *inode, sector_t sector, sector_t *phys,
> +		unsigned long *mapped_blocks, int *create)
> +{
…
> +	err = exfat_map_cluster(inode, clu_offset, &cluster,
> +		*create & BMAP_ADD_CLUSTER);

I find an other indentation more appropriate.
Please align the last parameter below (or besides) the opening parenthesis.


> +	if (err) {
> +		if (err != -ENOSPC)
> +			return -EIO;
> +		return err;
> +	}

Can such source code become more succinct?

+	if (err)
+		return err != -ENOSPC ? -EIO : err;

Regards,
Markus




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux