On 11.11.19 15:45, Markus Elfring wrote: > Date: Mon, 11 Nov 2019 15:20:44 +0100 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > Generated by: scripts/coccinelle/api/memdup_user.cocci > > * The function "_copy_apqns_from_user" contained a memory leak > because of a misssing function call "kfree(kapqns)" for an if branch. > Link: https://lore.kernel.org/r/833d7d5e-6ede-6bdd-a2cc-2da7f0b03908@xxxxxxxxxx/ > > Thus complete the exception handling by this code replacement. > > * Delete local variables which became unnecessary with this refactoring > in two function implementations. > > Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES cipher key support") > Signed-off-by: Markus Elfring <Markus.Elfring@xxxxxx> > --- > > v4: > Further changes were requested by Christian Bornträger. > https://lore.kernel.org/r/040f3e18-d97a-fc32-b237-20e7553e1733@xxxxxxxxxx/ > > * An other patch subject was selected. > > * An other email address was used for the tag “Signed-off-by” this time. applied. [...] > + if (!uapqns || nr_apqns <= 0) While applying I changed that to if (!uapqns || nr_apqns == 0) as nr_apqns is size_t and thus unsigned.
