Re: [PATCH v2] s390/pkey: Use memdup_user() rather than duplicating its implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 07.11.19 14:45, Markus Elfring wrote:
>>> Reuse existing functionality from memdup_user() instead of keeping
>>> duplicate source code.
>>>
>>> Generated by: scripts/coccinelle/api/memdup_user.cocci
>>>
>>> Delete local variables which became unnecessary with this refactoring
>>> in two function implementations.
>>>
>>> Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES cipher key support")
>>
>> With that patch description, the Fixes tag is wrong...but (see below)
> 
> I wonder about such a conclusion together with your subsequent feedback.

Please try to read and understand what other people write. My point was that your
patch description only talks about refactoring and avoiding code duplication.
So you do not claim to have fixed anything. You claim to have refactored things
to avoid code duplication. And no, refactoring is NOT a fix.

That fact that you fix a bug was obviously just by accident. So you have not even
noticed that your change was actually chaning the logical flow of the code. 

Now: When you change the patch description explaining what you fix, a Fixes tag is
appropriate. 




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux