Re: [v3] s390/pkey: Use memdup_user() rather than duplicating its implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christian Bornträger <borntraeger@xxxxxxxxxx>, linux-s390@xxxxxxxxxxxxxxx, Harald Freudenberger <freude@xxxxxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, Ingo Franzki <ifranzki@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Joe Perches <joe@xxxxxxxxxxx>
Subject: Re: [v3] s390/pkey: Use memdup_user() rather than duplicating its implementation
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Mon, 11 Nov 2019 09:11:04 +0100
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, Kangjie Lu <kjlu@xxxxxxx>, Navid Emamdoost <emamd001@xxxxxxx>, Stephen McCamant <smccaman@xxxxxxx>
In-reply-to: <040f3e18-d97a-fc32-b237-20e7553e1733@de.ibm.com>
References: <08422b7e-2071-ee52-049e-c3ac55bc67a9@web.de> <6137855bb4170c438c7436cbdb7dfd21639a8855.camel@perches.com> <deb7893f-3cfe-18fc-3feb-b26b290bf3c6@web.de> <833d7d5e-6ede-6bdd-a2cc-2da7f0b03908@de.ibm.com> <1b65bc81-f47a-eefa-f1f4-d5af6a1809c0@web.de> <733b29df-207e-a165-ee80-46be8720c0c4@de.ibm.com> <8f98f9fc-57df-5993-44b5-5ea4c0de7ef9@web.de> <c0df9cc8-c41a-1e5d-811c-1ff045c13fcc@de.ibm.com> <61244676-8ac1-20af-ed94-99e19c1f95d5@web.de> <040f3e18-d97a-fc32-b237-20e7553e1733@de.ibm.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

>> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>> Date: Fri, 8 Nov 2019 17:50:22 +0100
…
>> Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES cipher key support")
>> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>
> You were sending this from a different email address.

Yes.


> Can you use the same for the sender and the signoff?

I would prefer to use the other email address (for a while).


> Can you also change the subject to indicate the "fix". e.g. something like
>
> s390/pkey: fix memory leak in error case by using memdup_user() rather than open coding

Does this change request indicate also a need to split the software update
between the discussed two function implementations?

Regards,
Markus

Follow-Ups:
- Re: [v3] s390/pkey: Use memdup_user() rather than duplicating its implementation
  - From: Christian Borntraeger

References:
- [PATCH] s390/pkey: Use memdup_user() rather than duplicating its implementation
  - From: Markus Elfring
- Re: [PATCH] s390/pkey: Use memdup_user() rather than duplicating its implementation
  - From: Joe Perches
- [PATCH v2] s390/pkey: Use memdup_user() rather than duplicating its implementation
  - From: Markus Elfring
- Re: [PATCH v2] s390/pkey: Use memdup_user() rather than duplicating its implementation
  - From: Christian Borntraeger
- Re: [PATCH v2] s390/pkey: Use memdup_user() rather than duplicating its implementation
  - From: Markus Elfring
- Re: [PATCH v2] s390/pkey: Use memdup_user() rather than duplicating its implementation
  - From: Christian Borntraeger
- Re: s390/pkey: Use memdup_user() rather than duplicating its implementation
  - From: Markus Elfring
- Re: s390/pkey: Use memdup_user() rather than duplicating its implementation
  - From: Christian Borntraeger
- [PATCH v3] s390/pkey: Use memdup_user() rather than duplicating its implementation
  - From: Markus Elfring
- Re: [PATCH v3] s390/pkey: Use memdup_user() rather than duplicating its implementation
  - From: Christian Borntraeger

Prev by Date: Re: [PATCH v3] s390/pkey: Use memdup_user() rather than duplicating its implementation
Next by Date: Re: [v3] s390/pkey: Use memdup_user() rather than duplicating its implementation
Previous by thread: Re: [PATCH v3] s390/pkey: Use memdup_user() rather than duplicating its implementation
Next by thread: Re: [v3] s390/pkey: Use memdup_user() rather than duplicating its implementation
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]