On Thu, Oct 31, 2019 at 01:55:01PM +0300, Dan Carpenter wrote: > The "&fs_info->dev_replace.rwsem" and "&dev_replace->rwsem" refer to > the same lock but Smatch is not clever enough to figure that out so it > leads to static checker warnings. It's better to use it consistently > anyway. Both reasons, smatch and code consitency are fine, thanks. Reviewed-by: David Sterba <dsterba@xxxxxxxx>