On Sat, 2019-10-19 at 21:43 +0100, Marc Zyngier wrote: > Providing Coccinelle scripts that scream about perfectly valid code is > pointless, and the result is actively harmful. Doubtful. If the new code is smaller object code and correct than the conversion is worthwhile. fyi: There are already ~450 uses of this function and maybe ~800 possible additional conversions. > If said script was providing a correct semantic patch instead of being > an incentive for people to churn untested patches that span the whole > tree, that'd be a different story. Right.