Re: [PATCH] iio: light: cm36651: redundant assignment to variable ret

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun,  1 Sep 2019 16:27:49 +0100
Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> Variable ret is being assigned a value that is never read and
> is being re-assigned a little later on. The assignment is redundant
> and hence can be removed.
> 
> Addresses-Coverity: ("Ununsed value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to do not much with it.

Thanks,

Jonathan

> ---
>  drivers/iio/light/cm36651.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/cm36651.c b/drivers/iio/light/cm36651.c
> index 1019d625adb1..90e38fcc974b 100644
> --- a/drivers/iio/light/cm36651.c
> +++ b/drivers/iio/light/cm36651.c
> @@ -532,7 +532,7 @@ static int cm36651_write_prox_event_config(struct iio_dev *indio_dev,
>  					int state)
>  {
>  	struct cm36651_data *cm36651 = iio_priv(indio_dev);
> -	int cmd, ret = -EINVAL;
> +	int cmd, ret;
>  
>  	mutex_lock(&cm36651->lock);
>  




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux