Markus Elfring <Markus.Elfring@xxxxxx> writes: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Tue, 3 Sep 2019 14:56:16 +0200 > > The brelse() function tests whether its argument is NULL > and then returns immediately. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Acked-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> Thanks. > --- > fs/fat/dir.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/fat/dir.c b/fs/fat/dir.c > index 1bda2ab6745b..f4bc87a3c98d 100644 > --- a/fs/fat/dir.c > +++ b/fs/fat/dir.c > @@ -88,9 +88,7 @@ static int fat__get_entry(struct inode *dir, loff_t *pos, > int err, offset; > > next: > - if (*bh) > - brelse(*bh); > - > + brelse(*bh); > *bh = NULL; > iblock = *pos >> sb->s_blocksize_bits; > err = fat_bmap(dir, iblock, &phys, &mapped_blocks, 0, false); > -- > 2.23.0 > -- OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
