> -----Original Message----- > From: Fabio Estevam [mailto:festevam@xxxxxxxxx] > Hi Wei, > > On Tue, Dec 18, 2018 at 4:36 AM Wei Yongjun <weiyongjun1@xxxxxxxxxx> > wrote: > > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + if (!res) > > + return -EINVAL; > > base = devm_ioremap(dev, res->start, resource_size(res)); > > Wouldn't it be better to use devm_ioremap_resource(), which does the NULL > check? No, devm_ioremap_resource will call request_mem_region which we don't want as LPCG memory space may overlap with other modules within the same SS. This is something like the syscon device does: drivers/mfd/syscon.c. Regards Dong Aisheng
