Hi Wei, On Tue, Dec 18, 2018 at 4:36 AM Wei Yongjun <weiyongjun1@xxxxxxxxxx> wrote: > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) > + return -EINVAL; > base = devm_ioremap(dev, res->start, resource_size(res)); Wouldn't it be better to use devm_ioremap_resource(), which does the NULL check?