On 10/16/2018 06:59 AM, Dan Carpenter wrote: > On Mon, Oct 15, 2018 at 04:18:35PM +0000, Allan, Bruce W wrote: >>> -----Original Message----- >>> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxx] On Behalf >>> Of Dan Carpenter >>> Sent: Friday, October 12, 2018 12:17 AM >>> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>; Ertman, David M >>> <david.m.ertman@xxxxxxxxx> >>> Cc: kernel-janitors@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx >>> Subject: [Intel-wired-lan] [PATCH] ice: remove an unneeded NULL check >>> >>> We added a NULL check in commit 072f0c3db9da ("ice: Fix potential null >>> pointer issues") but it causes static checker warnings. >> >> Which static checker and with what options? >> > > Future versions of Smatch will complain probably. It turns out there > are many many unnecessary NULL checks and they seldome indicate a bug so > I'm waffling on this... I don't see how fi could ever be NULL. It's set to the address of fm_entry->fltr_info. Given that, it really seems like the check should go, since it is clearly unnecessary. -Dave > > regards, > dan carpenter > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@xxxxxxxxxx > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan >
