On Mon, Oct 15, 2018 at 04:18:35PM +0000, Allan, Bruce W wrote: > > -----Original Message----- > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxx] On Behalf > > Of Dan Carpenter > > Sent: Friday, October 12, 2018 12:17 AM > > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>; Ertman, David M > > <david.m.ertman@xxxxxxxxx> > > Cc: kernel-janitors@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx > > Subject: [Intel-wired-lan] [PATCH] ice: remove an unneeded NULL check > > > > We added a NULL check in commit 072f0c3db9da ("ice: Fix potential null > > pointer issues") but it causes static checker warnings. > > Which static checker and with what options? > Future versions of Smatch will complain probably. It turns out there are many many unnecessary NULL checks and they seldome indicate a bug so I'm waffling on this... regards, dan carpenter
