Re: [PATCH -next] dmaengine: sprd: Fix potential NULL dereference in sprd_dma_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/08/2018 02:05 PM, Vinod Koul wrote:
> On 08-05-18, 13:46, Lars-Peter Clausen wrote:
>> On 05/07/2018 03:40 AM, Wei Yongjun wrote:
>>>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> +	if (!res)
>>> +		return -EINVAL;
>>>  	sdev->glb_base = devm_ioremap_nocache(&pdev->dev, res->start,
>>>  					      resource_size(res));
>>
>> I think a better improvement would be to replace this with
>> devm_ioremap_resource() which has the NULL pointer check and some other
>> things built-in.
> 
> Sure feel free to send a patch :)
> 

I prefer to inspire others ;)
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux