On 08-05-18, 13:46, Lars-Peter Clausen wrote: > On 05/07/2018 03:40 AM, Wei Yongjun wrote: > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + if (!res) > > + return -EINVAL; > > sdev->glb_base = devm_ioremap_nocache(&pdev->dev, res->start, > > resource_size(res)); > > I think a better improvement would be to replace this with > devm_ioremap_resource() which has the NULL pointer check and some other > things built-in. Sure feel free to send a patch :) -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
