On Thu, 19 Apr 2018, Dan Carpenter wrote: > The indenting here is confusing. > > Also we don't check "ret". That isn't likely to cause a runtime issue > because if it fails here fails then we'd probably return -EINVAL at the > end anyway. But it does introduce a static checker warning since "val" > is only inititialized on the success path. > > drivers/regulator/ab8500.c:429 ab8500_regulator_get_mode() > error: uninitialized symbol 'val'. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
