The indenting here is confusing.
Also we don't check "ret". That isn't likely to cause a runtime issue
because if it fails here fails then we'd probably return -EINVAL at the
end anyway. But it does introduce a static checker warning since "val"
is only inititialized on the success path.
drivers/regulator/ab8500.c:429 ab8500_regulator_get_mode()
error: uninitialized symbol 'val'.
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index 83dba3fbfe0c..4fab417f1803 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -425,7 +425,10 @@ static unsigned int ab8500_regulator_get_mode(struct regulator_dev *rdev)
if (info->mode_mask) {
/* Dedicated register for handling mode */
ret = abx500_get_register_interruptible(info->dev,
- info->mode_bank, info->mode_reg, &val);
+ info->mode_bank,
+ info->mode_reg, &val);
+ if (ret)
+ return ret;
val = val & info->mode_mask;
val_normal = info->mode_val_normal;
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
