On Tue, Feb 27, 2018 at 09:44:41PM +0000, Winkler, Tomas wrote: > > > > On Tue, Feb 27, 2018 at 05:26:22PM +0000, Winkler, Tomas wrote: > > > > > > > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > > > > > > > Currently the driver spams the kernel log on unsupported ioctls > > > > which is unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this > > anyway. > > > > I suspect this was originally for debugging purposes but it really > > > > is not required so remove it. > > > > > > > > > > This is rather strange as most of the legimit applications are using > > > one IOCTL from kernel 3.0 Do you have any reference where this call is > > originated from, frankly this is the first time I got such complain. > > > > > > In any case it would be maybe better to change it a warn once call. > > > > Just drop the message, it should not be this easy for userspace to spam the > > kernel log. The patch looks fine to me. > > > Fair enough, add my ack too. > > Still I'm curious if this comes from the field. fuzzers are "in the field" :) -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
