RE: [PATCH] mei: remove dev_err message on an unsupported ioctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> Currently the driver spams the kernel log on unsupported ioctls which is
> unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this anyway.
> I suspect this was originally for debugging purposes but it really is not
> required so remove it.
>

This is rather strange as most of the legimit applications are using one IOCTL from kernel 3.0
Do you have any reference where this call is originated from, frankly this is the first time I got such complain.

In any case it would be maybe better to change it a warn once call.
 
Thanks
Tomas

> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/misc/mei/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index
> 758dc73602d5..7bb013644aeb 100644
> --- a/drivers/misc/mei/main.c
> +++ b/drivers/misc/mei/main.c
> @@ -507,7 +507,6 @@ static long mei_ioctl(struct file *file, unsigned int
> cmd, unsigned long data)
>  		break;
> 
>  	default:
> -		dev_err(dev->dev, ": unsupported ioctl %d.\n", cmd);
>  		rets = -ENOIOCTLCMD;
>  	}
> 
> --
> 2.15.1

��.n��������+%������w��{.n����z�ޗ�����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux