Re: [2/2] crypto: bcm: One function call less in do_shash() after error detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, linux-crypto@xxxxxxxxxxxxxxx
Subject: Re: [2/2] crypto: bcm: One function call less in do_shash() after error detection
From: SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 23 Feb 2018 09:23:00 +0100
Cc: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>, Colin Ian King <colin.king@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Rob Rice <rob.rice@xxxxxxxxxxxx>, Steve Lin <steven.lin1@xxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20180222134231.GC28447@gondor.apana.org.au>
References: <68946b12-83d6-ab74-fd54-71b23cf9b7ef@users.sourceforge.net> <55bdcf76-f1c9-180d-6798-959e617b10ac@users.sourceforge.net> <20180222134231.GC28447@gondor.apana.org.au>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

> This patch is pointless as kfree on NULL is a no-op.

I prefer to avoid unnecessary function calls generally.

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

References:
- [PATCH 0/2] crypto/bcm: Adjustments for do_shash()
  - From: SF Markus Elfring
- [PATCH 2/2] crypto: bcm: One function call less in do_shash() after error detection
  - From: SF Markus Elfring
- Re: [PATCH 2/2] crypto: bcm: One function call less in do_shash() after error detection
  - From: Herbert Xu

Prev by Date: Re: [0/8] target-iSCSI: Adjustments for several function implementations
Next by Date: Re: [0/8] target-iSCSI: Adjustments for several function implementations
Previous by thread: Re: [PATCH 2/2] crypto: bcm: One function call less in do_shash() after error detection
Next by thread: [PATCH] scsi: scsi_transport_spi make two const arrays static, shrinks object size
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]