Re: um: Use common error handling code in port_listen_fd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 23, 2017 at 11:01:05AM +0200, SF Markus Elfring wrote:
> > This business of moving the error code to the bottom of the function
> > just makes the code less readable.
> 
> I got an other software development opinion on this aspect.
> Could you become used to the proposed control flow structure
> in the affected function?
> 

No.  Don't do this.  It's pointless obfuscation.

> 
> > I know you never listen to anyone,
> 
> My response times might not fir to your preferences.
> 
> 
> > but you should stop doing it.
> 
> I am going to offer suggestions for change patterns which I find useful.
> There are some challenges around change acceptance as usual.

Yeah.  I knew it was pointless to ask you to stop this...  :(

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux