This business of moving the error code to the bottom of the function just makes the code less readable. I know you never listen to anyone, but you should stop doing it. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html