On Wed, Oct 18, 2017 at 06:43:10PM +0200, SF Markus Elfring wrote: > > Commit message should just describe in plain text what you are doing > > Did other contributors find the wording “Replace …” > > > > and why. > > and “… a bit safer according to the Linux coding style convention.” > sufficient often enough already? > > Which description would you find more appropriate for this change pattern? > > Regards, > Markus For 1/4 and 2/4: explain why the message can be omitted. Remove sentence about Coccinelle. That's all. 3/4: definitive NAK, too much noise compared to value. 4/4: this a good commit message. Requires a Tested-by before can be accepted, which I'm not able to give. Hope this helps. /Jarkko -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
