On Fri, Sep 29, 2017 at 05:45:54PM +0300, Leon Romanovsky wrote: > On Fri, Sep 29, 2017 at 01:40:04PM +0300, Dan Carpenter wrote: > > On Fri, Sep 29, 2017 at 01:29:29PM +0300, Leon Romanovsky wrote: > > > On Fri, Sep 29, 2017 at 10:49:43AM +0300, Dan Carpenter wrote: > > > > These lines were indented too far by mistake. > > > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > > > > > diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c > > > > > > Dan,, > > > > > > I saw in your patches and don't know if it important. There is no > > > diffstat after your Signed-off-by and there is no "---" trailing line > > > too. > > > > Yeah. I leave those out. I normally write two line patches like this > > one so the diffstat is normally -2+2 and I figure people will see that > > they're tiny just from glancing at the email. When I create patches > > that touch multiple files, what I do is just merge the diffs together in > > my email client. If I tried to create diffstats for those, I'd just end > > up messing up a lot. > > What are the benefits avoiding them? > The way I develop the kernel is way different from how other people do and different from how I develop Smatch. I've spent 9 years tweaking my scripts to make it work for me. Please don't force me to use git commit... :( regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
