On Fri, Sep 29, 2017 at 01:40:04PM +0300, Dan Carpenter wrote: > On Fri, Sep 29, 2017 at 01:29:29PM +0300, Leon Romanovsky wrote: > > On Fri, Sep 29, 2017 at 10:49:43AM +0300, Dan Carpenter wrote: > > > These lines were indented too far by mistake. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > > > diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c > > > > Dan,, > > > > I saw in your patches and don't know if it important. There is no > > diffstat after your Signed-off-by and there is no "---" trailing line > > too. > > Yeah. I leave those out. I normally write two line patches like this > one so the diffstat is normally -2+2 and I figure people will see that > they're tiny just from glancing at the email. When I create patches > that touch multiple files, what I do is just merge the diffs together in > my email client. If I tried to create diffstats for those, I'd just end > up messing up a lot. What are the benefits avoiding them? I personally want to see them without and conditions, for two reasons: 1. It helps me to see the scope of the change. 2. It allows me to simply copy/paste the name to the editor without need to remove "a/" or "b/" from the "diff --git" line. Thanks > > regards, > dan carpenter >
Attachment:
signature.asc
Description: PGP signature
