From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
The comparisons for integer low on low > INT_MAX and also
integer high > INT_MAX are never going to be true since an
int type cannot be greater than INT_MAX. Remove these redundant
checks.
Detected by: CoverityScan CID#1455245, 1455248 ("Operands don't affect
result (CONSTANT_EXPRESSION_RESULT)")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
drivers/thermal/broadcom/brcmstb_thermal.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
index 87b8e7a86ee3..bcb3945feea6 100644
--- a/drivers/thermal/broadcom/brcmstb_thermal.c
+++ b/drivers/thermal/broadcom/brcmstb_thermal.c
@@ -278,8 +278,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
dev_dbg(priv->dev, "set trips %d <--> %d\n", low, high);
if (low) {
- if (low > INT_MAX)
- low = INT_MAX;
avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_LOW, low);
avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_LOW, 1);
} else {
@@ -287,8 +285,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
}
if (high < ULONG_MAX) {
- if (high > INT_MAX)
- high = INT_MAX;
avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_HIGH, high);
avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_HIGH, 1);
} else {
--
2.14.1
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
