On 8/28/17 2:06 AM, Dan Carpenter wrote: > On Sun, Aug 27, 2017 at 11:16:06PM +0000, Waskiewicz Jr, Peter wrote: >> On 8/27/17 3:26 PM, SF Markus Elfring wrote: >>> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >>> Date: Sun, 27 Aug 2017 21:18:37 +0200 >>> >>> Omit an extra message for a memory allocation failure in this function. >>> >>> This issue was detected by using the Coccinelle software. >> >> Did coccinelle trip on the message or the fact you weren't returning NULL? >> > > You've misread the patch somehow. The existing code has a NULL return > and it's preserved in Markus's patch. This sort of patch is to fix a > checkpatch.pl warning. The error message from this kzalloc() isn't going > to get printed because it's a small allocation and small allocations > always succeed in current kernels. But probably the main reason > checkpatch complains is that kmalloc() already prints a stack trace and > a bunch of other information so the printk doesn't add anyting. > Removing it saves a little memory. > > I'm mostly a fan of running checkpatch on new patches or staging and not > on old code... And this is what I get for reading the patch with a crappy mailer...thanks Doubtlook. Sorry for the noise. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
