Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> The cast here is wrong. We want to cast the pointer but we accidentally
> do a no-op cast of the value. We normally want to set us_nav_upper to
> WIFI_NAV_UPPER_US (30000) but because of this bug we instead set it to
> 184 on little endian systems and 0 on big endian ones.
>
> Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> index 2bc6bace069c..230f92a48f3c 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> @@ -779,7 +779,7 @@ void rtl8821ae_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
> _rtl8821ae_resume_tx_beacon(hw);
> break; }
> case HW_VAR_NAV_UPPER: {
> - u32 us_nav_upper = ((u32)*val);
> + u32 us_nav_upper = *(u32 *)val;
>
> if (us_nav_upper > HAL_92C_NAV_UPPER_UNIT * 0xFF) {
> RT_TRACE(rtlpriv, COMP_INIT , DBG_WARNING,
Patch applied to wireless-drivers-next.git, thanks.
d28ac7be15c7 rtlwifi: rtl8821ae: Fix HW_VAR_NAV_UPPER operation
--
https://patchwork.kernel.org/patch/9837847/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
