Re: [PATCH] rtlwifi: rtl8821ae: Fix HW_VAR_NAV_UPPER operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 14, 2017 at 02:09:46PM -0500, Larry Finger wrote:
> On 07/13/2017 02:43 AM, Dan Carpenter wrote:
> > The cast here is wrong.  We want to cast the pointer but we accidentally
> > do a no-op cast of the value.  We normally want to set us_nav_upper to
> > WIFI_NAV_UPPER_US (30000) but because of this bug we instead set it to
> > 184 on little endian systems and 0 on big endian ones.
> > 
> > Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> 
> Thanks for catching this error. I suspect a typo, but your fix is obviously correct.
> 
> Does the "Fixes" notation imply a Cc to stable?

No.  Fixes doesn't necessarily imply a Cc to stable.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux