[bug report] irqdomain: Let irq_domain_mapping display hierarchical domains

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Marc Zyngier,

This is a semi-automatic email about new static checker warnings.

The patch fe17a42e704a: "irqdomain: Let irq_domain_mapping display 
hierarchical domains" from May 12, 2017, leads to the following 
Smatch complaint:

kernel/irq/irqdomain.c:772 virq_debug_show_one()
	 warn: variable dereferenced before check 'data' (see line 758)

kernel/irq/irqdomain.c
   757		while (domain) {
   758			unsigned int irq = data->irq;
                                           ^^^^^^^^^
Dereference.

   759			unsigned long hwirq = data->hwirq;
   760			struct irq_chip *chip;
   761			bool direct;
   762	
   763			if (data == &desc->irq_data)
   764				seq_printf(m, "%5d  ", irq);
   765			else
   766				seq_printf(m, "%5d+ ", irq);
   767			seq_printf(m, "0x%05lx  ", hwirq);
   768	
   769			chip = irq_data_get_irq_chip(data);
   770			seq_printf(m, "%-15s  ", (chip && chip->name) ? chip->name : "none");
   771	
   772			seq_printf(m, data ? "0x%p  " : "  %p  ",
                                      ^^^^
Too late to check.

   773				   irq_data_get_irq_chip_data(data));
   774	

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux