On 01/23/2017 05:06 AM, SF Markus Elfring wrote: >>> We have got different preferences for the placement of error code settings. >> Yes we do, so what's the point? Both are OK. > > Can a function implementation be executed a bit faster in the case > that error codes will usually only matter if they would be set after > a concrete software failure Don't turn this into a troll fest. Maintainability trumps performance. Every time. See previous email for reasoning for that. >> Please don't go down that road it opens so much potential for needless bikeshedding >> and waste all of our (including your) time. > > I would appreciate to clarify involved run time consequences a bit more. How about you go and benchmark the before and after, and present some compelling evidence based on those tests for why the change should be made? The onus is on the submitter here, not the reviewer. As I said in the previous email, don't bother sending these types of patches for the block layer again. They are just going to be ignored. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
