>> @@ -1327,27 +1327,30 @@ static ssize_t tg_set_max(struct kernfs_open_file *of,
>> break;
>> ctx.body += len;
>>
>> - ret = -EINVAL;
>> p = tok;
>> strsep(&p, "=");
>> - if (!p || (sscanf(p, "%llu", &val) != 1 && strcmp(p, "max")))
>> + if (!p || (sscanf(p, "%llu", &val) != 1 && strcmp(p, "max"))) {
>> + ret = -EINVAL;
>> goto out_finish;
>> + }
>
> Sorry, I don't like this patch. We know the next error if we encounter one
> will be EINVAL until we change it.
Thanks for your constructive feedback.
> Your patch doesn't introduce a functual change and doesn't improve readability,
> so I don't really see a point for it.
We have got different preferences for the placement of error code settings.
Do you care about run time changes there?
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
