> I have a personal style preference for
>
> rc = -ENOMEM;
> val = kalloc();
> if (!val)
> goto err;
>
> vs
>
> val = kalloc();
> if (!val) {
> rc = -ENOMEM;
> goto err;
> }
>
> because it saves 1 line
Thanks for your feedback.
> and I think the compiler does the right/same thing.
* Did you check any corresponding code generation results in more detail?
* Can misplaced variable assignments result in unwanted run time consequences
because of the previous approach for a control flow specification?
* How do you think about to achieve that error codes will only be set
after a specific software failure was detected?
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
