On Wed, Nov 30, 2016 at 07:02:09PM +0000, Vatsavayi, Raghu wrote:
> > 1005 oq_no++) {
> > 1006 if (!(oct->droq_intr & BIT_ULL(oq_no)))
> > 1007 continue;
> > 1008
> > 1009 droq = oct->droq[oq_no];
> > 1010
> > 1011 if (droq->ops.poll_mode) {
> > 1012 droq->ops.napi_fn(droq);
> > 1013 oct_priv->napi_mask |= (1 << oq_no);
> >
> > It should be 1ULL << oq_no. But the other bug is tahte ->napi_mask is a long
> > but that will break on 32 bit systems when
> > MAX_OCTEON_OUTPUT_QUEUES() is 64. Is that a possible combination?
> >
>
> [Raghu]: These drivers are for 64 bit systems as mentioned in Kconfig.
>
Ah... Grand. I see that now. Can you send a patch for the others?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
