Re: [patch] sparc64: enable IRQs on error paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On (11/25/16 16:01), Dan Carpenter wrote:
> I'm pretty sure the Fixes tag is correct.  Originally it did:
> 
> +iommu_map_fail:
> +       /* Interrupts are disabled.  */
> +       spin_lock(&iommu->lock);
> +       pci_arena_free(&iommu->arena, entry, npages);
> +       spin_unlock_irqrestore(&iommu->lock, flags);
> +

In that case why dont you just do the local_irq_restore
once at the iommu_map_fail label?

--Sowmini

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux