>>>> Move the setting for the local variables "mask", "match" and "rc6_csl" >>>> behind the source code for a condition check by this function >>>> at the beginning. >>> >>> Again, I can't see what the point is? >> >> * How do you think about to set these variables only after the initial >> check succeded? > > I prefer setting variables early so that no thinking about > whether they're initialized or not is necessary later. * How do you think about to reduce the scope for these variables then? * Would you dare to move the corresponding source code into a separate function? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
