Am 07.10.2016 10:37, schrieb SF Markus Elfring:
>>> Do not use curly brackets at one source code place
>>> where a single statement should be sufficient.
>>
>> The original style was correct and this is wrong. I have explained this before.
>
> Did I change a bit too much in the proposed step according to the following
> update suggestion?
>
> elfring@Sonne:~/Projekte/Linux/next-patched> git checkout d6385db94196b253ae5eb3678fa95cdf1f839fcc && scripts/checkpatch.pl --types BRACES -f drivers/md/md-cluster.c
> …
> WARNING: braces {} are not necessary for single statement blocks
> #1228: FILE: drivers/md/md-cluster.c:1228:
> + if (cinfo->other_bitmap_lockres[i]) {
> + lockres_free(cinfo->other_bitmap_lockres[i]);
> + }
> …
>
>
> How do you think about to adjust this source code place a bit?
>
perhaps we can agree to delete the if() block ?
static void lockres_free(struct dlm_lock_resource *res)
{
int ret;
if (!res)
return;
....
@marcus: is can not send mail to you sf.net adresse because sf.net
mark my domain als spam (note: nobody else does)
re,
wh
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
