On 07.10.2016 09:53, Dan Carpenter wrote: > On Thu, Oct 06, 2016 at 11:29:20AM +0200, Richard Weinberger wrote: >> On Thu, Oct 6, 2016 at 11:22 AM, SF Markus Elfring >> <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: >>> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >>> Date: Tue, 4 Oct 2016 21:46:18 +0200 >>> >>> Replace the specification of a data structure by a pointer dereference >>> as the parameter for the operator "sizeof" to make the corresponding size >>> determination a bit safer. >> >> Isn't this pure matter of taste? >> Some developers prefer sizeof(*ptr) because it is easier to type, other >> developers prefer sizeof(struct foo) because you can determine the type >> at first sight and makes review more easy. > > sizeof(*ptr) is more future proof and normally more obvious and easier > to review. Also a matter of taste. See http://yarchive.net/comp/linux/struct_init.html Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
