On Sun, 2016-09-25 at 13:13 +0200, SF Markus Elfring wrote: > The script "checkpatch.pl" can point out that assignments should usually > not be performed within condition checks. > Thus move the assignment for a variable to a separate statement > in four functions. Did you recycle this commit explanation? Because git diff tells me you actually touched about eight functions. > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/isdn/capi/capidrv.c | 59 +++++++++++++++++++++++++++------------------ > 1 file changed, 36 insertions(+), 23 deletions(-) So I ran checkpatch on this file, just like you did. Specifically, I did: scripts/checkpatch.pl -f drivers/isdn/capi/capidrv.c | grep "assignment in if condition" | wc -l It tells me there are actually 18 instances of this "ERROR". Why did you ignore one of it in this patch? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
