Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Marciniszyn, Mike" <mike.marciniszyn@xxxxxxxxx>
Subject: Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation
From: Leon Romanovsky <leon@xxxxxxxxxx>
Date: Fri, 19 Aug 2016 18:45:37 +0300
Cc: SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>, "linux-rdma@xxxxxxxxxxxxxxx" <linux-rdma@xxxxxxxxxxxxxxx>, Doug Ledford <dledford@xxxxxxxxxx>, Hal Rosenstock <hal.rosenstock@xxxxxxxxx>, "Hefty, Sean" <sean.hefty@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "kernel-janitors@xxxxxxxxxxxxxxx" <kernel-janitors@xxxxxxxxxxxxxxx>, Julia Lawall <julia.lawall@xxxxxxx>
In-reply-to: <32E1700B9017364D9B60AED9960492BC2D0AF84E@fmsmsx120.amr.corp.intel.com>
User-agent: Mutt/1.5.24 (2015-08-30)

On Fri, Aug 19, 2016 at 03:42:29PM +0000, Marciniszyn, Mike wrote:
> > >
> > > The bail_tmp: label is then not needed.
> > 
> > You still need to free tmp allocation if qib_eeprom_write failed and this is
> > your bail_tmp.
> > 
> 
> Typo.   The bail: label is not needed.

Yeah, it makes sense.

Thanks

> 
> Mike

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation
  - From: SF Markus Elfring
- RE: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation
  - From: Marciniszyn, Mike
- Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation
  - From: Leon Romanovsky
- RE: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation
  - From: Marciniszyn, Mike

Prev by Date: Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation
Next by Date: RE: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation
Previous by thread: RE: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation
Next by thread: Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]