On Fri, Aug 19, 2016 at 03:27:20PM +0000, Marciniszyn, Mike wrote:
> > Subject: [PATCH] IB/qib: Use memdup_user() rather than duplicating its
> > diff --git a/drivers/infiniband/hw/qib/qib_fs.c
>
> I would be even more aggressive at reducing lines of code.
>
> For example do direct returns when ok to do:
> if (pos != 0 || count != sizeof(struct qib_flash))
> return -EINVAL;
>
> tmp = memdup_user(buf, count);
> if (IS_ERR(tmp))
> return PTR_ERR(tmp);
>
> The bail_tmp: label is then not needed.
You still need to free tmp allocation if qib_eeprom_write failed and
this is your bail_tmp.
341 tmp = kmalloc(count, GFP_KERNEL);
342 if (!tmp) {
343 ret = -ENOMEM;
344 goto bail;
345 }
346
347 if (copy_from_user(tmp, buf, count)) {
348 ret = -EFAULT;
349 goto bail_tmp;
350 }
351
352 dd = private2dd(file);
353 if (qib_eeprom_write(dd, pos, tmp, count)) {
354 ret = -ENXIO;
355 qib_dev_err(dd, "failed to write to flash\n");
356 goto bail_tmp;
357 }
>
> Mike
>
Attachment:
signature.asc
Description: PGP signature
