> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 9 Jul 2015 09:52:24 +0200
>
> The unregister_sysctl_table() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/cdrom/cdrom.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index 5d28a45..e43e84d 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3698,8 +3698,7 @@ static void cdrom_sysctl_register(void)
>
> static void cdrom_sysctl_unregister(void)
> {
> - if (cdrom_sysctl_header)
> - unregister_sysctl_table(cdrom_sysctl_header);
> + unregister_sysctl_table(cdrom_sysctl_header);
> }
>
> #else /* CONFIG_SYSCTL */
>
How do you think about to integrate this update suggestion
into another source code repository?
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
