Re: [patch] IB/core: fix an error code in ib_core_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/31/2016 12:05 PM, Dan Carpenter wrote:
> We should return the error code if ib_add_ibnl_clients() fails.  The
> current code returns success.
> 
> Fixes: 735c631ae99d ('IB/core: Register SA ibnl client during ib_core initialization')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 5516fb0..8b8a8d9 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -1024,7 +1024,8 @@ static int __init ib_core_init(void)
>  		goto err_mad;
>  	}
>  
> -	if (ib_add_ibnl_clients()) {
> +	ret = ib_add_ibnl_clients();
> +	if (ret) {
>  		pr_warn("Couldn't register ibnl clients\n");
>  		goto err_sa;
>  	}
> 

Thanks, applied.

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux