Nice catch, looks good. Reviewed-by: Mark Bloch <markb@xxxxxxxxxxxx> > -----Original Message----- > From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx] > Sent: Tuesday, May 31, 2016 7:06 PM > To: Doug Ledford <dledford@xxxxxxxxxx>; Mark Bloch > <markb@xxxxxxxxxxxx> > Cc: Sean Hefty <sean.hefty@xxxxxxxxx>; Hal Rosenstock > <hal.rosenstock@xxxxxxxxx>; Matan Barak <matanb@xxxxxxxxxxxx>; Or > Gerlitz <ogerlitz@xxxxxxxxxxxx>; Ira Weiny <ira.weiny@xxxxxxxxx>; Haggai > Eran <haggaie@xxxxxxxxxxxx>; Leon Romanovsky > <leonro@xxxxxxxxxxxx>; Jason Gunthorpe > <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>; Yotam Kenneth (revoke on 13.10.15) > <yotamke@xxxxxxxxxxxx>; Parav Pandit <pandit.parav@xxxxxxxxx>; linux- > rdma@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: [patch] IB/core: fix an error code in ib_core_init() > > We should return the error code if ib_add_ibnl_clients() fails. The > current code returns success. > > Fixes: 735c631ae99d ('IB/core: Register SA ibnl client during ib_core > initialization') > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/infiniband/core/device.c > b/drivers/infiniband/core/device.c > index 5516fb0..8b8a8d9 100644 > --- a/drivers/infiniband/core/device.c > +++ b/drivers/infiniband/core/device.c > @@ -1024,7 +1024,8 @@ static int __init ib_core_init(void) > goto err_mad; > } > > - if (ib_add_ibnl_clients()) { > + ret = ib_add_ibnl_clients(); > + if (ret) { > pr_warn("Couldn't register ibnl clients\n"); > goto err_sa; > } -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
