Re: [patch v2] PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 26, 2016 at 10:56 PM, Dan Carpenter
<dan.carpenter@xxxxxxxxxx> wrote:
> On Thu, May 26, 2016 at 10:46:26PM +0900, Chanwoo Choi wrote:
>> On Thu, May 26, 2016 at 8:56 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>> > On Thu, May 26, 2016 at 05:12:19PM +0900, Chanwoo Choi wrote:
>> >> I don't recommend that you mention the name of engineer on patch description
>> >> directly.
>> >
>> > This really is normal.  I've been mentioned over 100 times in commit
>> > messages like 7051924f771 (xillybus: Move out of staging).
>>
>> I'm still reluctant to use the name on description.
>
> I understand that but I don't understand why, though.  Anyway, aren't
> forwarding this to someone?  You can change it to say whatever you want.

Because if the name without any unique email address is included in
the description,
I think that it is not appropriate. Always, the information should
include the email address.
So, I just prefer to use the Suggested-by or the different kind of tag
with [id: explanation].

But, I'll stop about it because it is not critical issue.
It depend on what is the preferred method to add the information.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux