Hi Dan, On 2016년 05월 26일 15:45, Dan Carpenter wrote: > Smatch complains because platform_get_resource() returns NULL on error > and not an error pointer so the check is wrong. Julia Lawall pointed > out that normally we don't check these, because devm_ioremap_resource() > has a check for NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > v2: just remove the check > > diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c > index 6b6a5f3..a584140 100644 > --- a/drivers/devfreq/event/exynos-nocp.c > +++ b/drivers/devfreq/event/exynos-nocp.c > @@ -220,9 +220,6 @@ static int exynos_nocp_parse_dt(struct platform_device *pdev, > > /* Maps the memory mapped IO to control nocp register */ > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (IS_ERR(res)) > - return PTR_ERR(res); > - > base = devm_ioremap_resource(dev, res); > if (IS_ERR(base)) > return PTR_ERR(base); I don't recommend that you mention the name of engineer on patch description directly. Except for this comment, looks good to me. Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
